Skip to content

Fix/pictique qr valid timer #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
grv-saini-20 wants to merge 2 commits into from
Closed

Fix/pictique qr valid timer #677

grv-saini-20 wants to merge 2 commits into from
+51 −3

Conversation

@grv-saini-20
Copy link
Collaborator

@grv-saini-20 grv-saini-20 commented Jan 16, 2026 •
edited by coderabbitai bot
Loading

Description of change

fixed the pictique welcome screen QR Validator.

Issue Number

closes #674

Type of change

  • Update (a change which updates existing functionality)
  • Fix (a change which fixes an issue)

How the change has been tested

Manual

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • New Features
    • Enhanced follow button interactions with smooth animations and scale effects when following users.
    • Added visual status indicators showing Follow, Following, and Followed states with animated feedback.
    • Improved real-time UI responsiveness during follow actions with disabled button states while requests are processing.

✏️ Tip: You can customize this high-level summary in your review settings.

@grv-saini-20 grv-saini-20 requested a review from coodos as a code owner January 16, 2026 06:31
@grv-saini-20 grv-saini-20 marked this pull request as draft January 16, 2026 06:31
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 16, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This PR enhances the Profile component's follow interaction by introducing animated button states, follow request tracking, and improved UI feedback when users follow or unfollow profiles, with state synchronized between the page handler and the Profile component.

Changes

Cohort / File(s) Summary
Follow Interaction UI Enhancement
platforms/pictique/src/lib/fragments/Profile/Profile.svelte		 Adds follow interaction enhancements for "other" variant profile: new isFollowing prop, requestSent state tracking, and btnScale Spring animation. Replaces simple Follow button with wrappedFollow flow that animates button scale, invokes handleFollow, marks request state, and restores scale. UI now displays Follow, Following (with bouncing indicator), and Followed (with Tick icon) states. Disables button during follow request or when already followed. Introduces HugeiconsIcon and Tick01Icon imports.
Follow State Management
platforms/pictique/src/routes/(protected)/profile/[id]/+page.svelte		 Adds local isFollowing state to track follow action status. Updates handleFollow to set isFollowing to true before sending POST request and reset it to false in finally block. Removes automatic profile fetch after follow (commented out). Binds isFollowing state to Profile component to reflect follow activity in UI.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Profile as Profile Component
    participant PageHandler as Page Handler
    participant API as API Server
    
    User->>Profile: Click Follow Button
    Profile->>Profile: Scale Button (Spring)
    Profile->>PageHandler: wrappedFollow() → handleFollow()
    PageHandler->>PageHandler: Set isFollowing = true
    PageHandler->>API: POST /follow
    API-->>PageHandler: Response
    PageHandler->>PageHandler: Set isFollowing = false (finally)
    PageHandler-->>Profile: Update isFollowing binding
    Profile->>Profile: Scale Button Back
    Profile->>Profile: Display Followed State + Tick Icon
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • fix: avatars #226: Modifies the same Profile.svelte component at the prop level and follow-button UI, creating a direct code interaction overlap with this PR's enhancements to the isFollowing prop and follow button flow.

Suggested reviewers

  • coodos
  • sosweetham

Poem

🐰 A follow button now bounces with glee,
With springs and animations for all eyes to see,
The state flows like carrots through component divine,
From click to server, then back in a line,
With a tick and a scale, the follow's all fine! ✨

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d6dc3c7 and 7a30535.

📒 Files selected for processing (2)
  • platforms/pictique/src/lib/fragments/Profile/Profile.svelte
  • platforms/pictique/src/routes/(protected)/profile/[id]/+page.svelte

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@grv-saini-20 grv-saini-20 self-assigned this Jan 16, 2026
@grv-saini-20
Copy link
Collaborator Author

grv-saini-20 commented Jan 16, 2026

changes are done in another pr

@grv-saini-20 grv-saini-20 deleted the fix/pictique-qr-valid-timer branch January 16, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coodos coodos Awaiting requested review from coodos coodos is a code owner

Assignees

@grv-saini-20 grv-saini-20

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Pictique issues

2 participants

@grv-saini-20